Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#246: Separate song management and update playlist metadata in playlist service #289

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

KristianLengyel
Copy link

@KristianLengyel KristianLengyel commented Nov 10, 2024

Description

This pull request separates the song management logic into two new methods: one for adding songs and one for removing songs from playlists. Additionally, it refines the update_playlist method by renaming it to update_playlist_metadata to enable selective field updates, ensuring only specified fields (new_name, description, photo) are updated without requiring all fields to be sent.

Commit type

  • feat: indicates the addition of new functionality for managing song additions/removals and updating playlist metadata selectively.

Issue

#246

Solution

The problem was resolved by implementing separate methods and endpoints for adding and removing songs from playlists, ensuring focused functionality. Additionally, the update_playlist method was renamed to update_playlist_metadata, now only requiring fields that need updating. This change allows the frontend to update playlist details more efficiently, reducing redundant data handling.

Proposed Changes

  • Create add_songs_to_playlist method to add songs to a playlist.
  • Create remove_songs_from_playlist method to remove songs from a playlist.
  • Rename update_playlist to update_playlist_metadata, enabling updates to only specified fields (new_name, description, photo).
  • Add endpoints in the controller for new song management functions.
  • Update and add test cases for new methods and adjusted update_playlist_metadata functionality.

Potential Impact

These changes streamline data transfer by minimizing the fields required for updates and isolating song management. However, any existing calls to the previous update_playlist method may need adjustment to align with the renamed method and modified endpoint behavior.

Screenshots

(No screenshots needed for backend changes)

Additional Tasks

  • Update any associated documentation with the new method and endpoint details.
  • Ensure that all test cases are passing and that test coverage is adequate.

Assigned

@AntonioMrtz

Kristuško and others added 4 commits November 26, 2024 17:16
…tional parameter type hints in api_test_playlist, and refactor update_playlist_metadata in base_user_repository and added tests in test__playlist
… adding helper functions and fixing Ruff errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playlist update only introduce fields to change
1 participant