New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixing builds with X11=OFF #927

Merged

pktiuk merged 1 commit into AntiMicroX:master from sjoblomj:fixing_builds_without_x11

Mar 3, 2024

Contributor

sjoblomj commented Mar 3, 2024

The code does not compile when building with X11=OFF:

cd antimicrox
mkdir build && cd build
cmake -DWITH_X11=OFF ..  # Fails!
cmake --build .

There are errors in two files that cause this.

In src/gui/addeditautoprofiledialog.cpp, the code attempts to call functions of dialog that are not present.
In src/gui/buttoneditdialog.cpp, there are two variables that have already been defined, which causes the compilation to fail.

This PR makes the code compile again.


          Fixing builds with X11=OFF

dc1ee34

sjoblomj force-pushed the fixing_builds_without_x11 branch from 6d7d862 to dc1ee34 Compare

March 3, 2024 10:31

Member

pktiuk commented Mar 3, 2024

@sjoblomj
Thank you for your contribution.

pktiuk merged commit 7006005 into AntiMicroX:master

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet