-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1 Add ressources for X52pro #17
base: master
Are you sure you want to change the base?
Conversation
- Add sources laylout for X52 in image - and futur blank folder for VOidCrew
Why do you think, that repository with antimicrox profiles needs some photos of a X52pro ? |
add void crew profils and layout
because antimicro's interface isn't clear at the moment, and a hotas has 60 buttons and axes, sometimes more, this kind of image is useful to avoid getting lost, I always add it for information with the profiles I create, so that the user knows what he's doing at first look. |
and the blank profils can be used in futur to make any profil and layout with this modle draw.io |
it never bothered jsbackus when I added it properly, and even back then I didn't know how to use Gitkraken which automatically created issues and linked them together. I use github web and it was a real pain to go through imgur. |
But in this PR did not do it properly. At the beginning just added a bunch of photos to a random directories, and you forgot about uploading any profile files. Images of controller layouts should be placed in the corresponding directories of apps not in the general drectory with images. |
it's not random it's named "X52" the name of the hotas, in "image" directory. |
modifie X/middleClic
@pktiuk commit update, ready to PR |
Please remove your changes from the directory Pictures next to AntiMicroX profile can stay as a descripton of profile. |
applications/VoidCrew-steam/03000000a3060000620700001101000016991890/Readme.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can talk about merging after changes
…991890/Readme.md Co-authored-by: Paweł Kotiuk <[email protected]>
any other modification ? |
Please read my comment above
|
the images are 8mo, it's ridiculous, and the github is not stored on your personal computer, why make manners for a blank image that will be used in other profile? |
I won't repeat myself. Do as you wish. I already clearly stated what comes into this repo and what does not. |
- Rename file to Button/axis - Remove Doublon sources file
I can delete some, but the goal is clearly to share ‘neutral’ images to facilitate the work of the community, and make the whole more pleasant to use. you also want to fraine the progress and contribution of the community on this subject too ? |
So please merge my PR and stop acting like a child, i have many friend waiting for this profiles merging on this github. the community github where i'm contributor from many year now. and no i don't have shre sources about layout on gamepad because all the gamepad look similary, hotas not, each hotas reference are difference. that why thi PR is important. |
I am not obligated in any way to merge every contribution which is submitted to the repositories I maintain. This repository has a clearly defined layout, and I am going to stick with it. I already defined everything what needs to be done to merge this PR. You can always have your own fork of this repo and manage it in any way you like. Maybe a general database of game controllers would be a good idea, but this is still out of scope of this repo. I am not going to waste more time for this discussion. This message is the first warning. |
my own fork would be of no use or interest, If the images are stored elsewhere, for example gdrive or dropbox, that would suit you ?
So tell me what to do. |
Just remove files not matching the layout of this repository. Everything is clearly defined in the README. |
Closes /Fr-Dae/issues/1
Closes #16