Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 Add ressources for X52pro #17

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Fr-Dae
Copy link

@Fr-Dae Fr-Dae commented Nov 15, 2024

Closes /Fr-Dae/issues/1

Closes #16

  • Add sources laylout for X52 in image
  • add a futur blank folder for VoidCrew
  • add voidcrew profils for x52

- Add sources laylout for X52 in image
- and futur blank folder for VOidCrew
@pktiuk
Copy link
Member

pktiuk commented Nov 15, 2024

Why do you think, that repository with antimicrox profiles needs some photos of a X52pro ?

add void crew profils and layout
@Fr-Dae
Copy link
Author

Fr-Dae commented Nov 15, 2024

because antimicro's interface isn't clear at the moment, and a hotas has 60 buttons and axes, sometimes more, this kind of image is useful to avoid getting lost, I always add it for information with the profiles I create, so that the user knows what he's doing at first look.

@Fr-Dae
Copy link
Author

Fr-Dae commented Nov 15, 2024

and the blank profils can be used in futur to make any profil and layout with this modle draw.io

@Fr-Dae
Copy link
Author

Fr-Dae commented Nov 15, 2024

it never bothered jsbackus when I added it properly, and even back then I didn't know how to use Gitkraken which automatically created issues and linked them together. I use github web and it was a real pain to go through imgur.

@pktiuk
Copy link
Member

pktiuk commented Nov 17, 2024

it never bothered jsbackus when I added it properly

But in this PR did not do it properly. At the beginning just added a bunch of photos to a random directories, and you forgot about uploading any profile files.

Images of controller layouts should be placed in the corresponding directories of apps not in the general drectory with images.

@Fr-Dae
Copy link
Author

Fr-Dae commented Nov 17, 2024

to a random directorie

it's not random it's named "X52" the name of the hotas, in "image" directory.
it's a blank layout, for the community can use it as a model for their own profiles,
then I added the profiles to the game folder with the keys, when it's tested and ready

modifie X/middleClic
@Fr-Dae
Copy link
Author

Fr-Dae commented Nov 19, 2024

@pktiuk commit update, ready to PR

@pktiuk
Copy link
Member

pktiuk commented Nov 22, 2024

Please remove your changes from the directory images there is no need to store images of controllers just in case. Everyone looking for pictures of this controller can just google it.

Pictures next to AntiMicroX profile can stay as a descripton of profile.

Copy link
Member

@pktiuk pktiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can talk about merging after changes

@Fr-Dae
Copy link
Author

Fr-Dae commented Nov 26, 2024

any other modification ?

@pktiuk
Copy link
Member

pktiuk commented Nov 26, 2024

Please read my comment above

Please remove your changes from the directory images there is no need to store images of controllers just in case. Everyone looking for pictures of this controller can just google it.

Pictures next to AntiMicroX profile can stay as a descripton of profile.

@Fr-Dae
Copy link
Author

Fr-Dae commented Nov 26, 2024

the images are 8mo, it's ridiculous, and the github is not stored on your personal computer, why make manners for a blank image that will be used in other profile?

@pktiuk
Copy link
Member

pktiuk commented Nov 26, 2024

there is no need to store images of controllers just in case. Everyone looking for pictures of this controller can just google it.

I won't repeat myself. Do as you wish. I already clearly stated what comes into this repo and what does not.

- Rename file to Button/axis
- Remove Doublon sources file
@Fr-Dae
Copy link
Author

Fr-Dae commented Nov 27, 2024

I can delete some, but the goal is clearly to share ‘neutral’ images to facilitate the work of the community, and make the whole more pleasant to use.
some people don't use draw.io XML files but only PNG files (the old ones from reddit for example)

you also want to fraine the progress and contribution of the community on this subject too ?

@Fr-Dae
Copy link
Author

Fr-Dae commented Nov 27, 2024

  • Does this PR violate github and opensource rules : NO
  • Does this PR quote its sources : YES
  • Does this PR improve the project : YES
  • Do this PR are link to a issue and comment commit ? : YES

So please merge my PR and stop acting like a child, i have many friend waiting for this profiles merging on this github. the community github where i'm contributor from many year now.

and no i don't have shre sources about layout on gamepad because all the gamepad look similary, hotas not, each hotas reference are difference. that why thi PR is important.
if I could get my hands on another model of hotas, I'd provide more useful data for the community as a whole. except that it's a slow process

@pktiuk
Copy link
Member

pktiuk commented Dec 8, 2024

I am not obligated in any way to merge every contribution which is submitted to the repositories I maintain. This repository has a clearly defined layout, and I am going to stick with it. I already defined everything what needs to be done to merge this PR.

You can always have your own fork of this repo and manage it in any way you like. Maybe a general database of game controllers would be a good idea, but this is still out of scope of this repo.

I am not going to waste more time for this discussion. This message is the first warning.

@Fr-Dae
Copy link
Author

Fr-Dae commented Dec 9, 2024

I am not obligated in any way to merge every contribution which is submitted to the repositories I maintain. This repository has a clearly defined layout, and I am going to stick with it. I already defined everything what needs to be done to merge this PR.

You can always have your own fork of this repo and manage it in any way you like. Maybe a general database of game controllers would be a good idea, but this is still out of scope of this repo.

I am not going to waste more time for this discussion. This message is the first warning.

my own fork would be of no use or interest,
basically your concern is that I quote my sources and make them available to the commu via your github?

If the images are stored elsewhere, for example gdrive or dropbox, that would suit you ?
I still have the X56 and the VBK which I must deal with, to discuss weeks with you for only one PR it is exhausting... especially for an image of 8mo.

open 3 weeks ago

So tell me what to do.

@pktiuk
Copy link
Member

pktiuk commented Dec 9, 2024

Just remove files not matching the layout of this repository. Everything is clearly defined in the README.
Files in the applications directory can stay. Others should be removed. I am not interested in images you placed in other directories.
That's it. I am also tired of this conversation, so I won't answer any further questions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ressource for X52pro layout
2 participants