Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] compute_transaction should return failure trace #2400

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 5, 2024

/v1/chain/compute_transaction API endpoint should return a failure trace.
This was accidently changed to false when refactoring send_transaction in 5.0.

See 4.0 impl:

app().get_method<incoming::methods::transaction_async>()(pretty_input, true /* api_trx */, trx_type, true /* return_failure_trace */,

Resolves #2281

@heifner heifner added the OCI Work exclusive to OCI team label Aug 5, 2024
@heifner heifner merged commit 63fec3e into release/5.0 Aug 5, 2024
29 checks passed
@heifner heifner deleted the GH-2281-compute_trx-5.0 branch August 5, 2024 21:09
@ericpassmore ericpassmore added the bug Something isn't working label Oct 2, 2024
@ericpassmore
Copy link
Contributor

ericpassmore commented Oct 2, 2024

Note:start
category: Other
component: Chain-Plugin
summary: Restore failure trace to compute_transaction.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants