Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Test: Verify needed trx processed before continuing #2365

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Mar 30, 2024

The test would wait on the last trx in a set before continuing. However, there is no guarantee that a previous trx is not retried because it didn't fit into a block. The test now verifies the complete set of trx are complete before continuing to the next step.

Resolves #2364

@heifner heifner linked an issue Mar 30, 2024 that may be closed by this pull request
@heifner heifner requested review from greg7mdp and linh2931 March 30, 2024 18:27
@heifner heifner added the OCI Work exclusive to OCI team label Mar 30, 2024
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: TEST
summary: Improve retry transaction test by waiting for previous transactions to complete.
Note:end

@heifner heifner merged commit f44409b into hotstuff_integration Apr 2, 2024
34 checks passed
@heifner heifner deleted the GH-2364-retry-test branch April 2, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IF: Test Failure: nodeos_retry_transaction_if_lr_test
4 participants