-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: Update fork database fork-choice rule #2273
Merged
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
472b1d4
GH-2125 Optimize fetch_block_branch
heifner 7c19670
GH-2125 Update best fork logic of fork_database.
heifner 8101af0
GH-2125 Update fork_database on strong vote
heifner 5d2a839
GH-2125 Make last_qc_block_num non-optional
heifner 29ddf49
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-21…
heifner 57371bd
GH-2125 Move get_activated_protocol_features to block_header_state[_l…
heifner 6ab1146
GH-2125 Remove fork database adaptors and use fork database accessors…
heifner f8828ac
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-21…
heifner d0f7bf7
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-21…
heifner 970528c
GH-2125 Add updated_core and most_recent_ancestor_with_qc to block_st…
heifner 9e0a226
GH-2125 Revert unneeded changes
heifner 17274e2
GH-2125 Potentially switch forks before beginning to produce a block
heifner 842ed6c
GH-2125 Can't have pending block when applying a block
heifner 37a7a17
GH-2125 Use vector instead of deque
heifner 042ffde
GH-2125 Return current state even on error
heifner 1eda923
GH-2125 Rename method to make more clear
heifner 2767821
GH-2125 Use descriptive types
heifner bc5d464
GH-2125 Change order of eval
heifner c3847eb
GH-2125 Improve logging
heifner 6a45921
GH-2125 Use descriptive enums instead of bools
heifner 69373f4
GH-2125 Revert unneeded change
heifner f9dd443
GH-2125 Remove duplicate
heifner 772d74e
GH-2125 Rename most_recent_ancestor_with_qc to best_qc_claim
heifner 2153ba2
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-21…
heifner 39b3d3f
GH-2125 Only update best qc on state changes
heifner 3ec3d79
GH-2125 Fix update_best_qc logic for processing descendants
heifner d9c1b87
GH-2125 use a counter instead of time to ensure unique
heifner e2f0d4d
GH-2125 Add some comments
heifner bbe24e7
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-21…
heifner 1471adc
GH-2125 Use simpler fork-choice rule that doesn't change with votes. …
heifner 0f521d4
GH-2125 Advance LIB on producer since producer does not receive its o…
heifner 48f2253
GH-2125 Update tests now that votes do not advance LIB
heifner cdb5381
GH-2125 trx can become irreversible much quicker than in non-IF
heifner f9fa56b
GH-2125 Improve test implementation
heifner 7f18b5b
GH-2125 Used claimed final_on_strong_qc_block_num
heifner c88d6e3
GH-2125 Add search_on_head_branch
heifner 14b04b0
GH-2125 Normalize types
heifner 93a7fee
GH-2125 Add fork_comparison for logging
heifner 04dcfeb
GH-2125 Additional type normalization
heifner fab0bbe
Use separate `by_best_branch` index definitions.
greg7mdp 31da03f
GH-2125 Remove unneeded bs acccessor methods. Use log_fork_comparison…
heifner bc827ec
GH-2125 Rename to make more descriptive
heifner ee5291f
GH-2125 Search on correct branch
heifner e3059bf
GH-2125 Fix compile error and some more type name changes
heifner 2a2a5da
GH-2125 Simplify search_on_head_branch_impl and add new test cases
heifner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment here saying the claim has already been verified before.