PH: Disable p2p trx execution on validation and api nodes #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwaldp-oci
approved these changes
Oct 3, 2023
linh2931
reviewed
Oct 4, 2023
| @@ -124,6 +124,7 @@ def __post_init__(self): | |||
|
|
|||
| def configureValidationNodes(): | |||
| validationNodeSpecificNodeosStr = "" | |||
| validationNodeSpecificNodeosStr += '--p2p-accept-transactions false ' | |||
There was a problem hiding this comment.
Why not remove the statement above and do validationNodeSpecificNodeosStr = '--p2p-accept-transactions false ' directly?
Same comment for below.
There was a problem hiding this comment.
You don't have to make the changes. I am approving it now so that it can make to 5.0.
There was a problem hiding this comment.
That would be a fine change. Previously all additions to validationNodeSpecificNodeosStr were conditional so it was needed to initialize the variable. Looks like down below apiNodeSpecificNodeosStr could've been initialized directly with the first option instead of to a blank string first.
linh2931
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance harness is evaluating performance of BP nodes or API nodes according to what they can individually handle. There is no need for the validation node or the API node to speculatively execute trxs. This removes load from the overall test rig allowing for better results. Also it better represents real-world API configuration.