Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Remove controller emit of hotstuff messages #1559

Merged
merged 5 commits into from
Aug 28, 2023
Merged

IF: Remove controller emit of hotstuff messages #1559

merged 5 commits into from
Aug 28, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 25, 2023 •
edited
Loading

  • No longer route hotstuff messages through the controller
  • Optimize sending of hotstuff messages in net_plugin

Resolves #1519

heifner
heifner commented Aug 25, 2023
View reviewed changes
plugins/net_plugin/include/eosio/net_plugin/net_plugin.hpp
@@ -26,7 +27,7 @@ namespace eosio {
net_plugin();
virtual ~net_plugin();

APPBASE_PLUGIN_REQUIRES((chain_plugin))
APPBASE_PLUGIN_REQUIRES((chain_plugin)(producer_plugin))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have always been here, but is now needed because of the call to producer_plugin in net_plugin::plugin_initialize.

@heifner heifner linked an issue Aug 25, 2023 that may be closed by this pull request
IF: Remove usage of emit from HotStuff code #1519
Closed
@heifner heifner added the OCI Work exclusive to OCI team label Aug 25, 2023
@heifner heifner mentioned this pull request Aug 28, 2023
Closed
greg7mdp
greg7mdp reviewed Aug 28, 2023
View reviewed changes
libraries/hotstuff/chain_pacemaker.cpp Show resolved Hide resolved
libraries/hotstuff/chain_pacemaker.cpp Show resolved Hide resolved
plugins/chain_plugin/chain_plugin.cpp Show resolved Hide resolved
plugins/net_plugin/net_plugin.cpp Outdated Show resolved Hide resolved
@greg7mdp
Copy link
Contributor

@spoonincode if you have some time, can you review this as Lin is OOO until wednesday noon?

@BenjaminGormanPMP BenjaminGormanPMP requested review from fcecin and removed request for linh2931 August 28, 2023 21:11
@heifner heifner merged commit 5dfa47d into hotstuff_integration Aug 28, 2023
22 checks passed
@heifner heifner deleted the GH-1519-rm-emit branch August 28, 2023 21:47
@heifner heifner mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@fcecin fcecin fcecin approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: Remove usage of emit from HotStuff code
3 participants
@heifner @greg7mdp @fcecin