Prometheus: Add speculative block metrics #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Aug 16, 2023
greg7mdp
approved these changes
Aug 16, 2023
dimas1185
reviewed
Aug 16, 2023
dimas1185
reviewed
Aug 17, 2023
| @@ -52,20 +52,42 @@ struct catalog_type { | |||
| Gauge& last_irreversible; | |||
| Gauge& head_block_num; | |||
|
|
|||
| struct block_metrics { | |||
| Counter& num_blocks; | |||
| Gauge& block_num; | |||
There was a problem hiding this comment.
I find block_num and num_blocks confusing naming. On lines 124 and 125 there is explanation. I suggest to name them accordingly to be self-descriptive. Something like that or maybe you have better ideas:
num_blocks -> produced_blocks_num
block_num -> cur_block_num
dimas1185
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added speculative block metrics:
total_time_us_produced_block - total time for produced block
idle_time_us_produced_block - idle time for produced block
num_success_trx_produced_block - number of successful transactions in produced block
success_trx_time_us_produced_block - time for successful transactions in produced block
num_failed_trx_produced_block - number of failed transactions during produced block
fail_trx_time_us_produced_block - time for failed transactions during produced block
num_transient_trx_produced_block - number of transient transactions during produced block
transient_trx_time_us_produced_block -time for transient transactions during produced block
other_time_us_produced_block - all other unaccounted time during produced block
block_num - current block number
blocks_speculative_num - number of speculative blocks created
total_time_us_speculative_block - total time for speculative block
idle_time_us_speculative_block - idle time for speculative block
num_success_trx_speculative_block - number of successful transactions in speculative block
success_trx_time_us_speculative_block - time for successful transactions in speculative block
num_failed_trx_speculative_block - number of failed transactions during speculative block
fail_trx_time_us_speculative_block - time for failed transactions during speculative block
num_transient_trx_speculative_block - number of transient transactions during speculative block
transient_trx_time_us_speculative_block - time for transient transactions during speculative block
other_time_us_speculative_block - all other unaccounted time during speculative block
Added the following to produced blocks:
nodeos_produced_elapsed_us_total - total produced blocks elapsed time
nodeos_produced_us_total - total produced blocks total time
Added the following to incoming blocks:
nodeos_incoming_elapsed_us_total - total incoming blocks elapsed time
nodeos_incoming_us_total - total incoming blocks total time
nodeos_incoming_us_block_latency - total incoming block latency
Resolves #1359