Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and define consistent pattern for leap plugin startup/shutdown. #1231

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Cleanup and define consistent pattern for leap plugin startup/shutdown. #1231

wants to merge 24 commits into from

Commits on May 25, 2023

  1. use appbase branch which calls plugin_shutdown() on exception.

    @greg7mdp
    greg7mdp committed May 25, 2023
    Configuration menu
    Copy the full SHA
    ee4e4b0 View commit details
    Browse the repository at this point in the history

  2. update appbase to new tip

    @greg7mdp
    greg7mdp committed May 25, 2023
    Configuration menu
    Copy the full SHA
    ee29899 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Do not destroy chain::controller on plugin_shutdown(). 

    as other plugins could possibly not be shutdown yet.
    @greg7mdp
    greg7mdp committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3812d5b View commit details
    Browse the repository at this point in the history

  2. No need to catch exceptions to make sure plugin_shutdown() is execu… 

    …ted.

This is now ensured with the current version of appbase.
    @greg7mdp
    greg7mdp committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3210dfe View commit details
    Browse the repository at this point in the history

  3. Whitespace fix

    @greg7mdp
    greg7mdp committed May 26, 2023
    Configuration menu
    Copy the full SHA
    81e5a81 View commit details
    Browse the repository at this point in the history

  4. In plugin_startup(), in case of error, better throw than call `ap… 

    …p().quit()`
    @greg7mdp
    greg7mdp committed May 26, 2023
    Configuration menu
    Copy the full SHA
    a2157c4 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Merge branch 'main' of github.com:AntelopeIO/leap into gh-672

    @greg7mdp
    greg7mdp committed May 30, 2023
    Configuration menu
    Copy the full SHA
    97aa420 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Remove unnecessary (now) try/catch block calling plugin_shutdown()

    @greg7mdp
    greg7mdp committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    dc72da4 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Merge branch 'main' of github.com:AntelopeIO/leap into gh-672

    @greg7mdp
    greg7mdp committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    a35e793 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Add usage_patterns.md file

    @greg7mdp
    greg7mdp committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a4f54a2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:AntelopeIO/leap into gh-672

    @greg7mdp
    greg7mdp committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    2bd8818 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:AntelopeIO/leap into gh-672

    @greg7mdp
    greg7mdp committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4869d63 View commit details
    Browse the repository at this point in the history

  4. Update usage_pattern.md

    @greg7mdp
    greg7mdp committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4224df0 View commit details
    Browse the repository at this point in the history

  5. fix typo

    @greg7mdp
    greg7mdp committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    48be938 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Merge branch 'main' of github.com:AntelopeIO/leap into gh-672

    @greg7mdp
    greg7mdp committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    839f5c9 View commit details
    Browse the repository at this point in the history

  2. Fix merge issue

    @greg7mdp
    greg7mdp committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    727175d View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Merge branch 'main' of github.com:AntelopeIO/leap into gh-672

    @greg7mdp
    greg7mdp committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    42ca516 View commit details
    Browse the repository at this point in the history

  2. Fix incorrect merge

    @greg7mdp
    greg7mdp committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    5291108 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:AntelopeIO/leap into gh-672

    @greg7mdp
    greg7mdp committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    ce96bf9 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Remove unneeded semicolumn

    @greg7mdp
    greg7mdp committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    64ef9ea View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:AntelopeIO/leap into gh-672

    @greg7mdp
    greg7mdp committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    42e8824 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Merge branch 'main' of github.com:AntelopeIO/leap into gh-672

    @greg7mdp
    greg7mdp committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    2ac21bc View commit details
    Browse the repository at this point in the history

  2. Don't throw when app().quit() called during plugin_startup.

    @greg7mdp
    greg7mdp committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    153ff89 View commit details
    Browse the repository at this point in the history

  3. Update appbase to branch tip

    @greg7mdp
    greg7mdp committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    b45ef19 View commit details
    Browse the repository at this point in the history