Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Modify set_proposed_producers() to make sure propser_schedule.version numbers not being skipped #2313

Closed
linh2931 opened this issue Mar 14, 2024 · 0 comments · Fixed by #2344
Assignees
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@linh2931
Copy link
Member

In reviewing #2282, @heifner commented:

I believe this change means it is now possible to skip propser_schedule.version numbers. We should modify the set_proposed_producers logic so we don't skip version numbers. Need a test to cover that case so we don't break it again.

We need to make sure that if a proposer policy is scheduled for the same proposer_policy.active_time that it replaces the current one there but doesn't increment the schedule version. I think we will need to change controller::set_proposed_producers to check if there is an existing one that would have the same active_time and replace it and use its version. We should return the correct version to the contract.

Please see #2282

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Mar 14, 2024
@heifner heifner changed the title IF: Modify et_proposed_producers() to make sure propser_schedule.version numbers not being skipped IF: Modify set_proposed_producers() to make sure propser_schedule.version numbers not being skipped Mar 14, 2024
@arhag arhag added 👍 lgtm and removed triage labels Mar 20, 2024
@heifner heifner self-assigned this Mar 27, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Mar 27, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Mar 27, 2024
heifner added a commit that referenced this issue Mar 27, 2024
@heifner heifner linked a pull request Mar 27, 2024 that will close this issue
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Mar 27, 2024
heifner added a commit that referenced this issue Mar 28, 2024
heifner added a commit that referenced this issue Mar 28, 2024
…ersion

IF: Set correct proposed producer schedule version
@heifner heifner closed this as completed Mar 28, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants