Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Set correct proposed producer schedule version #2344

Merged
merged 2 commits into from
Mar 28, 2024
Merged

IF: Set correct proposed producer schedule version #2344

merged 2 commits into from
Mar 28, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Mar 27, 2024

When set_proposed_producers replaces an existing in-flight producer schedule, use the existing in-flight producer schedule version so that versions are not skipped.

Resolves #2313

@heifner heifner linked an issue Mar 27, 2024 that may be closed by this pull request
IF: Modify set_proposed_producers() to make sure propser_schedule.version numbers not being skipped #2313
Closed
@heifner heifner added the OCI Work exclusive to OCI team label Mar 27, 2024
@heifner heifner requested review from linh2931 and greg7mdp March 27, 2024 19:05
greg7mdp
greg7mdp approved these changes Mar 27, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
@heifner heifner merged commit f0038dc into hotstuff_integration Mar 28, 2024
34 checks passed
@heifner heifner deleted the GH-2313-proposed_producers_version branch March 28, 2024 15:46
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Improvement to prevent proposer schedule version numbers from being skipping when an in-flight schedule is replaced.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: Modify set_proposed_producers() to make sure propser_schedule.version numbers not being skipped
4 participants
@heifner @ericpassmore @greg7mdp @linh2931