Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Don't drop late blocks #2159

Closed
Tracked by #2110
heifner opened this issue Jan 30, 2024 · 2 comments · Fixed by #2274
Closed
Tracked by #2110

IF: Don't drop late blocks #2159

heifner opened this issue Jan 30, 2024 · 2 comments · Fixed by #2274
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap v6.0.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Jan 30, 2024

Currently, any blocks received while producing a block are dropped and not evaluated. IF includes QC info in block extensions. Do not drop blocks, but rather incorporate their QC info into the fork_database. Do not automatically abort block but incorporate the block into the fork_database for use in best fork evaluation. If LIB advances such that current block being produced is no longer built on LIB, abort the block immediate, re-evaluate best fork, and build block off the new best fork.

Related to #2125
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 30, 2024
@arhag arhag mentioned this issue Jan 31, 2024
Closed
@arhag arhag added 👍 lgtm and removed triage labels Jan 31, 2024
@heifner heifner mentioned this issue Feb 6, 2024
Closed
@heifner
Copy link
Member Author

heifner commented Feb 6, 2024

I believe lib_advance_test can be updated to expect no unlinkable blocks after this change.

@heifner heifner mentioned this issue Feb 7, 2024
Merged
@heifner heifner self-assigned this Feb 20, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Feb 20, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Feb 20, 2024
@heifner heifner added this to the Leap v6.0.0-rc1 milestone Feb 20, 2024
@heifner heifner mentioned this issue Feb 29, 2024
Merged
heifner added a commit that referenced this issue Mar 1, 2024
@heifner
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-2159…
5b12ded 
…-late-blocks
heifner added a commit that referenced this issue Mar 1, 2024
@heifner
GH-2159 Add block_exists
80ee495
heifner added a commit that referenced this issue Mar 1, 2024
@heifner
GH-2159 Add accept_block
3c7a014
heifner added a commit that referenced this issue Mar 1, 2024
@heifner
Merge remote-tracking branch 'origin/GH-2125-forkdb-simpler' into GH-…
7aae8f0 
…2159-late-blocks
heifner added a commit that referenced this issue Mar 1, 2024
@heifner
Merge remote-tracking branch 'origin/GH-2125-forkdb-simpler' into GH-…
e02311f 
…2159-late-blocks
heifner added a commit that referenced this issue Mar 1, 2024
@heifner
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-2159…
93679b7 
…-late-blocks
heifner added a commit that referenced this issue Mar 1, 2024
@heifner
GH-2159 Use block id for irreversible so correct branch is made irrev…
fdf3029 
…ersible
heifner added a commit that referenced this issue Mar 1, 2024
@heifner
GH-2159 Update test to expect no unlinkable blocks under IF
345cceb
@heifner heifner mentioned this issue Mar 1, 2024
Merged
@heifner heifner linked a pull request Mar 1, 2024 that will close this issue
IF: Don't drop late blocks #2274
Merged
heifner added a commit that referenced this issue Mar 1, 2024
@heifner
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-2159…
b03584e 
…-late-blocks
heifner added a commit that referenced this issue Mar 1, 2024
@heifner
GH-2159 Allow a few unlinkable because of net_plugin accepting curren…
0a6127d 
…t block while syncing
heifner added a commit that referenced this issue Mar 1, 2024
@heifner
GH-2159 Use block_ref now that it is available on core
71c5479
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Mar 2, 2024
heifner added a commit that referenced this issue Mar 3, 2024
@heifner
GH-2159 Add comment
59b3c17
heifner added a commit that referenced this issue Mar 4, 2024
@heifner
GH-2159 Misc cleanup
e990500
heifner added a commit that referenced this issue Mar 4, 2024
@heifner
Merge pull request #2274 from AntelopeIO/GH-2159-late-blocks
8fee9b8 
IF: Don't drop late blocks
@heifner
Copy link
Member Author

heifner commented Mar 4, 2024

Resolved by #2274

@heifner heifner closed this as completed Mar 4, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: Don't drop late blocks AntelopeIO/leap
3 participants
@heifner @arhag @enf-ci-bot