P2P: Reset syncing on unlinkable blocks #2220
Merged
+287
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Feb 7, 2024
linh2931
reviewed
Feb 7, 2024
tests/lib_advance_test.py
Outdated
| maxActiveProducers=3 | ||
| totalProducers=maxActiveProducers | ||
| cluster=Cluster(unshared=args.unshared, keepRunning=args.leave_running, keepLogs=args.keep_logs) | ||
| activateIF=args.activate_if |
There was a problem hiding this comment.
This should be removed for main.
linh2931
approved these changes
Feb 7, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block producers drop blocks when producing. If a block producer is syncing when they start producing blocks, they will drop blocks causing unlinkable blocks on blocks processed after block production is complete.
Reset sync on unlinkable blocks allowing node to more quickly recover.
Adds new
lib_advance_test.pywhich fails without PR changes.Related #2159
Related #2133
Resolves #2215