eos_vm 7% perf improvement by optimizing the expensive get_imported_functions_size function.
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
changed the title
get_imported_functions_size function.eos_vm 7% perf improvement by optimizing the expensive get_imported_functions_size function.
heifner
approved these changes
Oct 23, 2024
linh2931
reviewed
Oct 23, 2024
linh2931
approved these changes
Oct 23, 2024
linh2931
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the performance of
eos-vmby about 7% (reduces total time from 6.8% to 1.55%, however the time spent inexecuteis 75% of the total execution time forapi_part2_tests).Running the perf tool, I noticed that
get_imported_functions_sizewas one of the top cpu users. Most of the time is spent callingsize()and doing an unnecessary check (that_index, theiin the loop, is less than size()).This streamlines the code.
pre optimization:
post optimization:
Also fixes an incorrect
std::forwarduse, of no consequense since the forwarded data has no pointers and is moved anyways.