Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add local binding constraints #5

Merged
merged 26 commits into from
Sep 27, 2024

Conversation

Sigurd-Borge
Copy link
Collaborator

Possible to create a binding constraint as well as add terms, tmie series are created with default zeroes if not provided

…int service potentially duplicating the bindingconstraints in memory. Also fixed a default value and a documentation gap
Added tox and tox-uv to allow for fast testing with multiple python versions.

Changed exact dependencies to allow patch dependencies in requirements.txt and requirements-dev.txt
…f the study to allow correct handling of ini file
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit :), just minor comments

requirements-dev.txt Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
src/antares/model/binding_constraint.py Show resolved Hide resolved
src/antares/model/binding_constraint.py Show resolved Hide resolved
src/antares/model/binding_constraint.py Outdated Show resolved Hide resolved
src/antares/model/binding_constraint.py Show resolved Hide resolved
src/antares/model/study.py Show resolved Hide resolved
src/antares/service/base_services.py Outdated Show resolved Hide resolved
src/antares/tools/contents_tool.py Show resolved Hide resolved
@Sigurd-Borge
Copy link
Collaborator Author

Think I've replied to all of them.

@MartinBelthle MartinBelthle self-requested a review September 27, 2024 14:43
@Sigurd-Borge Sigurd-Borge merged commit 3643b47 into main Sep 27, 2024
4 checks passed
@Sigurd-Borge Sigurd-Borge deleted the feat/add_local_binding_constraints branch September 27, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants