Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(link): add comment attribute in link that was missing and causing an 422 error #2281

Merged
merged 3 commits into from
Jan 6, 2025
Merged

fix(link): add comment attribute in link that was missing and causing an 422 error #2281

merged 3 commits into from
Jan 6, 2025

Conversation

TheoPascoli
Copy link
Contributor

@TheoPascoli TheoPascoli commented Jan 6, 2025 •
edited
Loading

"comment" fields can exist in Links, therefore we need it in the model so pydantic does not raise an error

MartinBelthle
MartinBelthle requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test where we have this value inside the .ini file and the GET /links called inside the map succeeds ?

MartinBelthle
MartinBelthle approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for me. just add 'link' in the PR name to make it more explicit

@TheoPascoli TheoPascoli force-pushed the fix/link-comment-attribute-missing branch from e670a7b to 872bf06 Compare January 6, 2025 12:36
@TheoPascoli TheoPascoli changed the title fix: add comment attribute that was missing and causing an 422 error fix: add comment attribute in link that was missing and causing an 422 error Jan 6, 2025
@TheoPascoli TheoPascoli changed the title fix: add comment attribute in link that was missing and causing an 422 error fix(link): add comment attribute in link that was missing and causing an 422 error Jan 6, 2025
@TheoPascoli TheoPascoli merged commit 345b0a7 into dev Jan 6, 2025
13 checks passed
@TheoPascoli TheoPascoli deleted the fix/link-comment-attribute-missing branch January 6, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinBelthle MartinBelthle MartinBelthle approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheoPascoli @MartinBelthle