Combat automation specific attacks #196

paiva92 · 2024-04-13T07:03:35Z

Se implementan los ataques específicos al combate: Derribo, Inconciencia, Inutilizar, Desarmar, Presa, Ataque Apuntado.
Se añade la solicitud de tirada de dado al WebSocket del Combat Manager para las tiradas de Resistencia, y Crítico.
Se añade penalizadores de Dolor, Carencia física y Resistir el dolor para automatizar el efectos de los Críticos.
Se añade Macro para la carga de Zeon, preparar conjuro y liberar Zeon - mysticActMacro
Se añaden las metamagias y se automatizan las siguientes en el combate:

Incremento Destructivo: añade daño base a los hechizos
Erudición Defensiva: bono a la proyección mágica defensiva
Erudición Ofensiva: bono a la proyección mágica ofensiva
Proyección mágica determinada: sobrescribe la proyección mágica
Explotación de la energía: bono al ACT por punto de cansancio utilizado (implementado en mysticActMacro)

…pecific-attacks

…cific-attacks

…pecific-attacks

Eryx5502

Publico comentarios que tenía pendientes de cuando revisé la pr, por si son de utilidad al extraer de la misma funcionalidades.

Eryx5502 · 2024-06-16T19:00:38Z

src/lang/en.json

  "macros.combat.dialog.rollResistanceButton.title": "Roll Resistance",
+  "macros.combat.dialog.rollResistanceCriticButton.title": "Roll Critical Resist",
+  "macros.combat.dialog.rollOppousedCheckButton.title": "Roll Characteristic",


Esta errata está en muchos de los sitios en los que aparece. Habría que arreglarlos todos. Por otro lado... sabemos si este es el nombre oficial de "tirada enfrentada" en inglés?

Suggested change

"macros.combat.dialog.rollOppousedCheckButton.title": "Roll Characteristic",

"macros.combat.dialog.rollOpposedCheckButton.title": "Roll Characteristic",

Eryx5502 · 2024-06-16T19:03:36Z

src/lang/en.json

+  "macros.mysticAct.dialog.spareActConfirm.body.title": "Do you want to make use of the Spare ACT?",
+  "macros.mysticAct.dialog.spareActConfirm.title": "You still have {spareAct} ACT",
+  "macros.mysticAct.dialog.message.title": "Accumulate <b>{act}</b> Zeon",
+  "macros.dialog.error.multipleSelectedToken.title": "Only can select one token",


Suggested change

"macros.dialog.error.multipleSelectedToken.title": "Only can select one token",

"macros.dialog.error.multipleSelectedToken.title": "You must select a single token",

Eryx5502 · 2024-06-16T19:08:02Z

src/lang/es.json

+  "macros.combat.dialog.oppousedCheck.characteristic.strength.title": "Fuerza",
+  "macros.combat.dialog.oppousedCheck.characteristic.agility.title": "Agilidad",
+  "macros.combat.dialog.oppousedCheck.characteristic.dexterity.title": "Destreza",


Ya existen traducciones para "Fuerza", "Destreza" y "Agilidad". Habría que usar esas (anima.ui.characteristics.[caracteristica]) en lugar de crear nuevas.

Eryx5502 · 2024-06-16T19:10:04Z

src/lang/es.json

+  "macros.mysticAct.dialog.button.spareAct.title": "ACT Excedente",
+  "macros.mysticAct.dialog.button.releaseAct.title": "Liberar Zeon",
+  "macros.mysticAct.dialog.button.withstandPain.title": "Resistir Dolor",
+  "macros.mysticAct.dialog.spareActConfirm.body.title": "Quieres hacer uso del ACT Excedente",


En general, en otras preguntas, cerramos el signo de interrogación pero no lo abrimos. Quizá en castellano deberíamos poner también el signo de abrir interrogación...

Suggested change

"macros.mysticAct.dialog.spareActConfirm.body.title": "Quieres hacer uso del ACT Excedente",

"macros.mysticAct.dialog.spareActConfirm.body.title": "¿Quieres hacer uso del ACT Excedente?",

Eryx5502 · 2024-06-16T19:42:20Z

src/module/actor/ABFActorSheet.js

+    html.find('.toggle-effects-button').click(async e => {
+      const { effectsItemId } = e.currentTarget.dataset;
+      const item = this.actor.items.get(effectsItemId);
+      const effects = this.actor.getEmbeddedCollection('ActiveEffect').contents;
+      const relevantEffects = effects.filter(effect =>
+        effect.origin.endsWith(effectsItemId)
+      );
+
+      if (relevantEffects.length === 0) {
+        return;
+      }
+
+      const newStatus = !item.system.activeEffect.enabled;
+
+      for (const effect of relevantEffects) {
+        await effect.update({ disabled: !newStatus });
+      }
+      return item.update({ 'system.activeEffect.enabled': newStatus });
+    });
+


Es posible que este código sea viejo y se haya quedado ahí residual? Creo que no hay ningún elemento del html con la clase .toggle-effects-button.

Está en el groups.hbs... Se llega a usar en algún sitio?

Eryx5502 · 2024-08-17T19:54:39Z

src/module/combat/websocket/ws-combat/gm/WSGMCombatManager.js

-                  distance
-                );
+                  distance,
+                  specialPorpuseAttack);


Suggested change

specialPorpuseAttack);

specialPurposeAttack);

Eryx5502 · 2024-08-17T19:55:00Z

src/module/combat/websocket/ws-combat/gm/WSGMCombatManager.js

@@ -291,6 +333,7 @@ export class WSGMCombatManager extends WSCombatManager {
              const { projectile } = result.values;
              const { damage } = result.values;
              const { distance } = result.values;
+              const { specialPorpuseAttack } = result.values;


Suggested change

const { specialPorpuseAttack } = result.values;

const { specialPurposeAttack } = result.values;

Eryx5502 · 2024-08-17T19:57:27Z

src/module/combat/websocket/ws-combat/gm/WSGMCombatManager.js

-    distance
-  ) {
+    distance,
+    specialPorpuseAttack) {


Suggested change

specialPorpuseAttack) {

specialPurposeAttack) {

Eryx5502 · 2024-08-17T19:57:59Z

src/module/combat/websocket/ws-combat/gm/WSGMCombatManager.js

@@ -336,7 +379,8 @@ export class WSGMCombatManager extends WSCombatManager {
        visible,
        projectile,
        damage,
-        distance
+        distance,
+        specialPorpuseAttack


Suggested change

specialPorpuseAttack

specialPurposeAttack

Eryx5502 · 2024-08-17T20:38:59Z

src/module/dialogs/combat/CombatAttackDialog.js

@@ -43,6 +47,16 @@ const getInitialData = (attacker, defender, options = {}) => {
        enable: combatDistance,
        check: false
      },
+      specialPorpuseAttacks: [


Suggested change

specialPorpuseAttacks: [

specialPurposeAttacks: [

Eryx5502 · 2024-10-02T19:03:48Z

Como dijimos, en lugar de resolver los conflictos vamos a extraer las funcionalidades para re-implementarlas por separado en las próximas versiones. He publicado los comentarios de revisión por si sirven de utilidad al extraer las funcionalidades.

paiva92 added 30 commits January 30, 2024 22:29

specificAttacks-and-resistance-overhauled

98b2614

specific-attacks-macro-execution

c5125d2

fix-psychicImbalanceCheck-and-check-result

f41a974

code-aesthetic-mystic

a388b41

critic-automation

aabe156

fix-localization-criticIfBeAble

cb31fdc

fix-executeMacro-resistanceRoll

71bef2b

fix-critic-location-side

afaf929

fix-psychic-projection

16f1cbd

techniques-sheet-active-effects

f3747d5

hotfix-all-attacks-ignores-armor

d6eb742

actor-active-effects

22d1716

specific-attacks-combat-damage-fix

7e5bdf1

new-critic-penalty-flag-hook

e0c6179

new-domineTechniqueEvaluate-actor

955c728

rebase-fixes

6fd2e58

update-3 equals to

ffb5b59

update-PP

492c163

fix-accumulateDefenses

58a7a78

fix-rebase

9c34db9

remove-domine technique active effects

26cff91

revamp-criticPenalty + pain modifiers

c0ef608

visual - painModifiers

474c284

replace visuals-effects for status

04733d7

Merge branch 'feature/new-combat-automation' into combat-automation-s…

a1eaaba

…pecific-attacks

Merge branch 'feature/new-combat-automation' into combat-automation-s…

1743d69

…pecific-attacks

fix - specificAttack

0c49037

fix-mutate ACT interger

a95ecc4

fix-localization combat Modifiers

66ab55a

added - endCombat physicalPainDisappearing

82cc682

paiva92 added 20 commits March 8, 2024 01:42

update - metamagic advancedZeonRegeneration

724be63

update - flag lastDefinedMagicProjection

cdf766e

fix - flag lastDefinedMagicProjection

43e8bbc

update - metamagics supernaturalShield

f998766

update - metamagic preparedSpell and supernatural shield

1cffd03

Merge branch 'develop/new-combat-automation' into combat-automation-s…

9160816

…pecific-attacks

update - spellDamage actor method

cebd160

Merge branch 'feature/metaMagic-in-combat' into combat-automation-spe…

9253e84

…cific-attacks

update - rename wrong english properties

e9072c9

fix - fatigueUsedBonus

b44b255

Merge branch 'feature/macro-mystic-act' into feature/metaMagic-in-combat

8b2fdfb

Merge branch 'develop/new-combat-automation' into combat-automation-s…

e7e80aa

…pecific-attacks

fix - metamagic increasedDestruction when baseDamage is 0

0a664de

fix - spellCasting async get Data CombatDefense

d2b736b

fix - async mysticCanCastEvaluate

cf238b5

Merge branch 'develop/new-combat-automation' into combat-automation-s…

f799d94

…pecific-attacks

update - painModifieres for penalties

bd70bdc

new - immuneToCritic

d9332ac

update - criticRoll display

d5a11c9

Merge branch 'develop/new-combat-automation' into combat-automation-s…

2774a6b

…pecific-attacks

paiva92 requested a review from Eryx5502 April 13, 2024 07:06

paiva92 self-assigned this Apr 13, 2024

Base automatically changed from develop/new-combat-automation to feature/new-combat-automation May 7, 2024 07:26

Base automatically changed from feature/new-combat-automation to main May 7, 2024 07:26

Eryx5502 added this to the v1.19.0 milestone May 8, 2024

Eryx5502 linked an issue Jun 13, 2024 that may be closed by this pull request

[🇪🇸 - Feature request] Automatización ataques críticos #103

Open

Eryx5502 mentioned this pull request Jun 20, 2024

[ES - Feature request] Extraer datos de los hechizos / poderes psíquicos / normas especiales armas #192

Open

3 tasks

Eryx5502 reviewed Oct 2, 2024

View reviewed changes

Eryx5502 closed this Oct 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Combat automation specific attacks #196

Combat automation specific attacks #196

paiva92 commented Apr 13, 2024 •

edited

Loading

Eryx5502 left a comment

Eryx5502 Jun 16, 2024

Eryx5502 Jun 16, 2024

Eryx5502 Jun 16, 2024

Eryx5502 Jun 16, 2024

Eryx5502 Jun 16, 2024

Eryx5502 Aug 19, 2024

Eryx5502 Aug 17, 2024

Eryx5502 Aug 17, 2024

Eryx5502 Aug 17, 2024

Eryx5502 Aug 17, 2024

Eryx5502 Aug 17, 2024

Eryx5502 commented Oct 2, 2024

	"macros.combat.dialog.rollOppousedCheckButton.title": "Roll Characteristic",
	"macros.combat.dialog.rollOpposedCheckButton.title": "Roll Characteristic",

	"macros.dialog.error.multipleSelectedToken.title": "Only can select one token",
	"macros.dialog.error.multipleSelectedToken.title": "You must select a single token",

	"macros.mysticAct.dialog.spareActConfirm.body.title": "Quieres hacer uso del ACT Excedente",
	"macros.mysticAct.dialog.spareActConfirm.body.title": "¿Quieres hacer uso del ACT Excedente?",

	const { specialPorpuseAttack } = result.values;
	const { specialPurposeAttack } = result.values;

Combat automation specific attacks #196

Combat automation specific attacks #196

Conversation

paiva92 commented Apr 13, 2024 • edited Loading

Eryx5502 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eryx5502 commented Oct 2, 2024

paiva92 commented Apr 13, 2024 •

edited

Loading