Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Python 3.12, Django 5.0. #267

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

sdolemelipone
Copy link
Collaborator

Bumped test suite. Is it time to remove testing for 3.0 and 3.1 now?
https://endoflife.date/django

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25ac5da) 88.77% compared to head (7d215b0) 88.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files           6        6           
  Lines         490      490           
  Branches       54       50    -4     
=======================================
  Hits          435      435           
  Misses         40       40           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jonashaag jonashaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If there is no reason to not keep supporting them, I suggest to keep them in the pipeline. If we want to make a change that's hindered by 3.0/3.1 support, we can drop it.

@sdolemelipone
Copy link
Collaborator Author

👍 Sounds good!

@jonashaag jonashaag merged commit 9a6bf95 into AndrewIngram:master Jan 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants