[RHELC-1098] Change Action results so that no information is given in…

… SUCCESS results (oamg#900) * [RHELC-1098] Change Action results so that no information is given in SUCCESS results * Update convert2rhel/unit_tests/actions/actions_test.py Co-authored-by: E Gustavsson <[email protected]> --------- Co-authored-by: E Gustavsson <[email protected]>
Andrew-ang9 · Oct 31, 2023 · dfbb8ee · dfbb8ee
1 parent c40d90c
commit dfbb8ee
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/convert2rhel/actions/__init__.py b/convert2rhel/actions/__init__.py
@@ -377,6 +377,11 @@ class ActionResult(ActionMessageBase):
     def __init__(
         self, level="SUCCESS", id="SUCCESS", title="", description="", diagnosis="", remediation="", variables=None
     ):
+        if level == "SUCCESS":
+            if description or diagnosis or remediation:
+                raise InvalidMessageError(
+                    "Success results cannot have description, diagnosis or remediation fields set"
+                )
         if not id:
             raise InvalidMessageError("Results require the id field")
 

diff --git a/convert2rhel/unit_tests/actions/actions_test.py b/convert2rhel/unit_tests/actions/actions_test.py
@@ -1681,6 +1681,26 @@ def test_action_message_success(self, level, id, title, description, diagnosis,
     @pytest.mark.parametrize(
         ("id", "level", "title", "description", "diagnosis", "remediation", "variables", "expected"),
         (
+            (
+                "SUCCESS",
+                "SUCCESS",
+                "Success title",
+                "Successful description",
+                "Successful diagnosis",
+                "Successful remediation",
+                {},
+                "Success results cannot have description, diagnosis or remediation fields set",
+            ),
+            (
+                "SUCCESS",
+                "SUCCESS",
+                "Success title",
+                "Successful description",
+                None,
+                None,
+                {},
+                "Success results cannot have description, diagnosis or remediation fields set",
+            ),
             (
                 None,
                 "ERROR",