Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to preload a collision mesh #67

Merged

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented May 7, 2024

Description

In my application, I sometimes have to do computations on the mesh before adding it in the collision scene. To avoid loading a mesh twice, this PR allows users to either pass in the mesh filepath, or pass in the mesh itself.

Testing

  • Launch the simulated panda arm: ros2 launch panda_moveit_config ex_fake_control.launch.py
  • Add a collision mesh, verify it works: ros2 run pymoveit2 ex_collision_mesh.py --ros-args -p position:="[0.5, 0.0, 0.5]" -p quat_xyzw:="[0.0, 0.0, -0.7071, 0.7071]" -r preload_mesh:="True"

Copy link
Owner

@AndrejOrsula AndrejOrsula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can see this being useful. Thank you @amalnanavati

@AndrejOrsula AndrejOrsula merged commit 3896807 into AndrejOrsula:devel May 10, 2024
2 checks passed
@amalnanavati amalnanavati deleted the amaln/preload_mesh branch May 10, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants