Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzy harmonic devel #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Kaiser1401
Copy link

Changes for Ros-Jazzy and Gazebo Harmonic

alongside AndrejOrsula/panda_ign_moveit2#34

@Kaiser1401
Copy link
Author

This is basically working together with the mentioned PR in the panda_ign_moveit2 repo.
See Issue #28 though, but that is outside of the port here i fear

Copy link
Owner

@AndrejOrsula AndrejOrsula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! I left a question and some suggestions.

I suppose the primary branch will need to be branched into fortress before merging this.

Comment on lines -46 to +54
default_value="panda",
description="Name or filepath of model to load.",
default_value=path.join(
get_package_share_directory("panda_description"),
"panda",
"model.sdf",
),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit suprised cause everything looked like it should have been working at some time, though i could not ifgure why :)
Had not seen the script or environment hooks prior, will have to check it out. Maybe it's because I'm using zsh and I'd have to have a corresponding zsh hook there. Will try to check

examples/py/ex_throw_object.py Outdated Show resolved Hide resolved
package.xml Show resolved Hide resolved
Kaiser1401 and others added 2 commits June 11, 2024 13:25
Co-authored-by: Andrej Orsula <[email protected]>
Co-authored-by: Andrej Orsula <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants