-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jazzy harmonic devel #27
base: master
Are you sure you want to change the base?
Conversation
…s not wait when still in planning
This is basically working together with the mentioned PR in the panda_ign_moveit2 repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR! I left a question and some suggestions.
I suppose the primary branch will need to be branched into fortress
before merging this.
default_value="panda", | ||
description="Name or filepath of model to load.", | ||
default_value=path.join( | ||
get_package_share_directory("panda_description"), | ||
"panda", | ||
"model.sdf", | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? The path was intended to be updated to include this model via this CMake hook: https://github.com/AndrejOrsula/panda_ign_moveit2/blob/be5704c5b8ede1ae3998db8285473e6da300cfc0/panda_description/cmake/environment_hooks/sdf_path.bash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a bit suprised cause everything looked like it should have been working at some time, though i could not ifgure why :)
Had not seen the script or environment hooks prior, will have to check it out. Maybe it's because I'm using zsh and I'd have to have a corresponding zsh hook there. Will try to check
Co-authored-by: Andrej Orsula <[email protected]>
Co-authored-by: Andrej Orsula <[email protected]>
Changes for Ros-Jazzy and Gazebo Harmonic
alongside AndrejOrsula/panda_ign_moveit2#34