-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unnamed bnbt tags #89
Conversation
I'm not familiar with C++ and PyBind, so my implementation is probably a bit sketchy. (I mean it works and doesn't change the current C++ API too much) |
You have made some good progress. I don't know if I like that Leaving the return type as |
The problem with putting |
Oops I didn't see your last line about code duplication on the C++ side, that is pretty annoying indeed... |
Okay, the |
I forgot it was used in writing as well. It doesn't make sense there. It can be left as an extra parameter. |
@gentlegiantJGC Sorry for the ping. |
Description
This PR adds support for reading/writing unnamed binary NBT tags. See #88 for potential use cases.
Reading: TODO
Writing: the
name
parameter ofto_nbt()
andsave_to()
now supportsNone
, which would write an unnamed tag.Progress