[chore]: Update Leaflet types #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdegraaf
reviewed
Aug 20, 2024
Comment on lines
11
to
17
| const convertCoordsToLatLng = (coordinates: LatLngTuple) => { | ||
| const coordsWithoutAltitude = [coordinates[0], coordinates[1]] | ||
|
|
||
| return coordsWithoutAltitude | ||
| .sort((a, b) => (a > b ? 1 : -1)) | ||
| .reverse() as LatLngTuple | ||
| } |
There was a problem hiding this comment.
I think it is a bit strange the type is casted to the same incomming type while the function converts it to a different structure. An idea to create a new LatLng type which is used as return type for this function? This should also be used where you change the type to [number,number] now. Like this:
vdegraaf
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.