Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug-5429]: Add isBlocking to input validator map #2715

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

OscarBakker
Copy link
Contributor

how to test

  • run backend and frontend with fetchQuestionsFromBackend to true (docker compose up -d in both signals and signals frontend)
  • then add two questions where the alert is triggered on the first option of the first question:
Screenshot 2023-09-25 at 14 21 48 Screenshot 2023-09-25 at 14 22 39
  • it should init the 'harde stop'

Ticket: SIG-5429

Signalen

Before opening a pull request, please ensure:

  • Make sure your PR title follows naming conventions: [feat-1234]: name feature
  • Double-check your branch is based on main and targets main
  • Pull request has tests (we are going for 100% coverage!)
  • Code is well-commented, linted and follows project conventions
  • Committed source code is headed by the correct SPDX license expression

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)

Copy link
Contributor

@vdegraaf vdegraaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OscarBakker OscarBakker merged commit 48b9d22 into main Sep 27, 2023
9 checks passed
@OscarBakker OscarBakker deleted the bug/5429-add-isBlocking-to-input-validator-map branch September 27, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants