Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIJN-9914-Chore - Also Add BA #1682

Merged
merged 2 commits into from
Dec 19, 2024
Merged

MIJN-9914-Chore - Also Add BA #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7bf06e
Also Add BA
timvanoostrom Dec 19, 2024
2f920e0
Re-use existing
timvanoostrom Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/server/services/afis/afis-facturen.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const ROUTES = {
},
deelbetalingen: (uri: string) =>
decodeURI(uri).includes(
`IsCleared eq false and InvoiceReference ne '' and (AccountingDocumentType eq 'AB')`
`IsCleared eq false and InvoiceReference ne '' and`
),
};

Expand Down Expand Up @@ -699,13 +699,7 @@ describe('afis-facturen', async () => {
},
};

remoteApi
.get((uri) =>
decodeURI(uri).includes(
`IsCleared eq false and InvoiceReference ne '' and (AccountingDocumentType eq 'AB')`
)
)
.reply(200, deelbetalingenResponse);
remoteApi.get(ROUTES.deelbetalingen).reply(200, deelbetalingenResponse);

const params: AfisFacturenParams = {
state: 'deelbetalingen',
Expand Down
2 changes: 1 addition & 1 deletion src/server/services/afis/afis-facturen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const accountingDocumentTypesByState: Record<
open: ['DR', 'DG', 'DM', 'DE', 'DF', 'DV', 'DW'],
afgehandeld: ['DR', 'DE', 'DM', 'DV', 'DG', 'DF', 'DM', 'DW'],
overgedragen: ['DR', 'DE', 'DM', 'DV', 'DG', 'DF', 'DM', 'DW'],
deelbetalingen: ['AB'],
deelbetalingen: ['AB', 'BA'],
};

const select = `$select=IsCleared,ReverseDocument,Paylink,PostingDate,ProfitCenterName,DocumentReferenceID,AccountingDocument,AmountInBalanceTransacCrcy,NetDueDate,DunningLevel,DunningBlockingReason,SEPAMandate,ClearingDate,PaymentMethod`;
Expand Down
Loading