Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdaniels/opentelemetry #888

Closed
wants to merge 8 commits into from
Closed

bdaniels/opentelemetry #888

wants to merge 8 commits into from

Conversation

barrydaniels-nl
Copy link
Contributor

Don't forget about...

  • Tests
  • Documentation in dev-docs/
  • Readable commit messages explaining the reason for changes

Replace this text with a summary of the PR.
Use AB#xyz to reference issue xyz on Azure DevOps.

@vdboor
Copy link
Contributor

vdboor commented Oct 1, 2024

This will no longer log to Azure audit logging (AZURE_APPI_AUDIT_CONNECTION_STRING). I'm already looking into that for Haal-Centraal-Proxy

vdboor
vdboor requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@vdboor vdboor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the audit logging (i'm already checking for options in haal-centraal-proxy)

@vdboor
Copy link
Contributor

vdboor commented Nov 7, 2024

Merged via #901

@vdboor vdboor closed this Nov 7, 2024
@barrydaniels-nl barrydaniels-nl deleted the bdaniels/opentelemetry branch November 24, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdboor vdboor vdboor requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barrydaniels-nl @vdboor @gurustacks