Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of view tests (no test changes) #863

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

vdboor
Copy link
Contributor

@vdboor vdboor commented Aug 1, 2024

While working on new functionality/tests, this helped to maintain a sense of overview.. To avoid complex review, I'd rather offer this part first. This splits a 2500+ line file into separate readable chunks.

Copy link
Contributor

@barrydaniels-nl barrydaniels-nl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdboor vdboor merged commit d227569 into master Aug 1, 2024
6 checks passed
@vdboor vdboor deleted the diederik/cleanup-view-tests branch August 1, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants