Fix timezone passing to datetime, since Django 4.2 uses zoneinfo #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdboor
force-pushed
the
diederik/django42-timezone
branch
from
97479cc to
65e991f
Compare
vdboor
force-pushed
the
diederik/django42-timezone
branch
from
65e991f to
fd69e98
Compare
This ruff fix previously didn't work on Django 3.2 as that uses pytz. Passing such timezone to datetime causes +00:18 min shifts instead of the expected +01:00 change. This is caused by the way pytz handles the zoneinfo from history and needs pytz.timezone.localize() to create the proper timezone information. See: https://groups.google.com/g/django-users/c/rXalwEztfr0/m/QAd5bIJubwAJ
vdboor
force-pushed
the
diederik/django42-timezone
branch
from
fd69e98 to
c188aa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ruff fix previously didn't work on Django 3.2 as that uses pytz. Passing such timezone to datetime causes +00:18 min shifts instead of the expected +01:00 change.
This is caused by the way pytz handles the zoneinfo from history and needs pytz.timezone.localize() to create the proper timezone information. See: https://groups.google.com/g/django-users/c/rXalwEztfr0/m/QAd5bIJubwAJ