fix: Resolve malformed outline and remove excessive whitespace on dialog #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpens
reviewed
Dec 15, 2023
github-actions
bot
temporarily deployed
to
demo-dialog-visual-design
github-actions
bot
temporarily deployed
to
demo-dialog-visual-design
alimpens
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why we had a padding on the footer, next to the gap on the dialog? It doubles the whitespace between body and footer and that’s not intended.
Safari distorts the focus outline on the close button because of the visually hidden label inside. Apparently, the
visually-hiddenclass doesn’t account for that. I added a quick workaround, also because we’re working on Icon Button anyway?