Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust size of breadcrumb separator and allow natural text wrapping #913

Merged
merged 10 commits into from
Dec 13, 2023
Merged

fix: Adjust size of breadcrumb separator and allow natural text wrapping #913

merged 10 commits into from
Dec 13, 2023

Conversation

VincentSmedinga
Copy link
Contributor

@VincentSmedinga VincentSmedinga commented Dec 10, 2023 •
edited
Loading

  • Adjusts the size of the separator from 1rem to 1ex
  • Makes the separator black instead of blue
  • Allows text within an item to wrap
  • Improves the Storybook example

@github-actions github-actions bot temporarily deployed to demo-DES-538-DES-539-breadcrumb-chevron-and-wrap December 12, 2023 12:01 Destroyed
@VincentSmedinga VincentSmedinga marked this pull request as draft December 12, 2023 12:02
@github-actions github-actions bot temporarily deployed to demo-DES-538-DES-539-breadcrumb-chevron-and-wrap December 12, 2023 12:55 Destroyed
@VincentSmedinga VincentSmedinga marked this pull request as ready for review December 12, 2023 12:57
@VincentSmedinga VincentSmedinga deleted the fix/DES-538-DES-539-breadcrumb-chevron-and-wrap branch December 12, 2023 13:14
@VincentSmedinga VincentSmedinga restored the fix/DES-538-DES-539-breadcrumb-chevron-and-wrap branch December 12, 2023 13:15
@github-actions github-actions bot temporarily deployed to demo-DES-538-DES-539-breadcrumb-chevron-and-wrap December 12, 2023 13:15 Destroyed
@VincentSmedinga
Copy link
Contributor Author

Renaming the branch closed the PR, that wasn’t intended.

@github-actions github-actions bot temporarily deployed to demo-DES-538-DES-539-breadcrumb-chevron-and-wrap December 12, 2023 23:13 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-538-DES-539-breadcrumb-chevron-and-wrap December 13, 2023 13:06 Destroyed
@VincentSmedinga VincentSmedinga merged commit caba940 into develop Dec 13, 2023
4 checks passed
@VincentSmedinga VincentSmedinga deleted the fix/DES-538-DES-539-breadcrumb-chevron-and-wrap branch December 13, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimpens alimpens alimpens approved these changes

@dlnr dlnr dlnr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentSmedinga @dlnr @alimpens