Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add text input component #912

Merged
merged 7 commits into from
Dec 11, 2023
Merged

feat: Add text input component #912

merged 7 commits into from
Dec 11, 2023

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Dec 8, 2023

Out of scope:

  • Passing the following types as a prop:

    • email
    • password
    • search
    • tel
    • text
    • url

@github-actions github-actions bot temporarily deployed to demo-531-add-text-input-component December 8, 2023 17:17 Destroyed
VincentSmedinga
VincentSmedinga approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think we need more docs about how to use form fields exactly, but that’s a larger operation so let’s get going with this start.

@github-actions github-actions bot temporarily deployed to demo-531-add-text-input-component December 11, 2023 11:02 Destroyed
@VincentSmedinga VincentSmedinga merged commit d4401cc into develop Dec 11, 2023
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feat/531-add-text-input-component branch December 11, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentSmedinga VincentSmedinga VincentSmedinga approved these changes

@dlnr dlnr Awaiting requested review from dlnr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alimpens @VincentSmedinga