Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean up redundant subcomponent types #894

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Dec 6, 2023

No description provided.

@VincentSmedinga
Copy link
Contributor

Is something like ‘Remove redundant children props from components` a better PR title to go into the change log? Child components are not the same as subcomponents, right?

@github-actions github-actions bot temporarily deployed to demo-clean-up-types December 6, 2023 15:13 Destroyed
@alimpens
Copy link
Contributor Author

alimpens commented Dec 7, 2023

Is something like ‘Remove redundant children props from components` a better PR title to go into the change log? Child components are not the same as subcomponents, right?

No, that's not quite what this PR does. I removed the redundant children prop in Accordion, but the larger point of this PR is to remove double type definitions. For Accordion for example, AccordionProps is an extension of HTMLAttributes<HTMLDivElement>. In AccordionComponent, we define HTMLAttributes<HTMLDivElement> again, and add AccordionProps to it, so HTMLAttributes<HTMLDivElement> is defined twice.

@VincentSmedinga VincentSmedinga merged commit 0c4bbc1 into develop Dec 8, 2023
4 checks passed
@VincentSmedinga VincentSmedinga deleted the refactor/clean-up-types branch December 8, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants