Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use highlight in footer #813

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

VincentSmedinga
Copy link
Contributor

@VincentSmedinga VincentSmedinga commented Nov 25, 2023

The background colour of Footer.Top can be applied through a blue Highlight.

@github-actions github-actions bot temporarily deployed to demo-use-highlight-in-footer November 25, 2023 00:58 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat: Use highlight in footer refactor: Use highlight in footer Nov 25, 2023
@alimpens
Copy link
Contributor

Maybe not a decision we have to make now: can't we get rid of the Footer component entirely? Footer just renders a HTML footer, Footer.Bottom renders a div, and Footer.Top is a Highlight. Maybe we can just turn this into a recipe or something, instead of a component?

@VincentSmedinga
Copy link
Contributor Author

Maybe not a decision we have to make now: can't we get rid of the Footer component entirely? Footer just renders a HTML footer, Footer.Bottom renders a div, and Footer.Top is a Highlight. Maybe we can just turn this into a recipe or something, instead of a component?

While I agree that the footer for our websites can technically be implemented through composition and configuration, I also think there’s value in having a semantic component that people don’t have to think twice about. Even if it’s not doing that much, having a thing called footer can be reassuring that they use the right thing in the right way.

Additionally, the footer has specific usage guidelines (prescribing what goes in which column) and its documentation is easier found if it’s an independent component.

@VincentSmedinga VincentSmedinga merged commit 78c5d7a into develop Nov 27, 2023
7 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/use-highlight-in-footer branch November 27, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants