Simplify viewports in Storybook #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’re simplifying the list of viewports in Storybook with which people can get an indication of how a component will work on a phone, tablet or desktop computer.
Our responsive framework is ready to serve any screen resolution, but we’re not going to design every component or screen in every one of them. Our designers are used to making high-fidelity designs in Figma and need some control over the width of the frames they create and the measurements of our layout and typography at these widths.
We have decided to go with 320, 832 and 1600 as reference widths for design. It seems logical to match that list in Storybook. I tried to find logical heights to match.