Add compact grid #758
Merged
Add compact grid #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-450-compact-grid
github-actions
bot
temporarily deployed
to
demo-DES-450-compact-grid
github-actions
bot
temporarily deployed
to
demo-DES-450-compact-grid
github-actions
bot
temporarily deployed
to
demo-DES-450-compact-grid
github-actions
bot
temporarily deployed
to
demo-DES-450-compact-grid
alimpens
reviewed
Nov 16, 2023
This reverts commit b09357d.
dlnr
reviewed
Nov 17, 2023
github-actions
bot
temporarily deployed
to
demo-DES-450-compact-grid
github-actions
bot
temporarily deployed
to
demo-DES-450-compact-grid
github-actions
bot
temporarily deployed
to
demo-DES-450-compact-grid
github-actions
bot
temporarily deployed
to
demo-DES-450-compact-grid
alimpens
previously approved these changes
Nov 17, 2023
alimpens
approved these changes
Nov 17, 2023
github-actions
bot
temporarily deployed
to
demo-DES-450-compact-grid
alimpens
added a commit
that referenced
this pull request
Nov 17, 2023
* Add padding classes * Rename padding to space and use margin * Use padding again because of collapsing margins * Allow start alignment of screen * Remove explicit horizontal centring of grid * Implement dense grid * Add documentation * Make spacing a local prop for Grid for now * Document vertical spacing * Rename ‘space’ to ‘margin’ * Finish rename * Prevent using vertical margin together with top or bottom * Update design documentation * Remove unnecessary test * Halve the number of margin classes with local custom properties * Add compact story and a control for density * Revert "Allow start alignment of screen" This reverts commit b09357d. * Improve documentation and story controls * Capitalise column headers * Rename ‘margin’ to ‘padding’ * Remove docs covered by TypeScript types Co-authored-by: Vincent Smedinga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
densitypropertymargin*padding-*propertiesa property forScreento left-align it.These changes were made in the context of a prototype. Although we prefer pull requests to focus on one feature, in this case I think it would not be efficient to split them up after the fact.
The sizing of the compact grid has been presented to teams currently designing applications. They are evaluating but I don’t expect any changes.
Implementing generic utility classes for spacing seemed a bridge too far. They’re only available to the grid. Consequently, the class names are many and verbose for now.
A next step is to implement a concept of ‘theming’, as we want all grid instances to have the same density and to have typography react to the same setting. After that, we can extend the
marginprops to generic utility classes.I’ve removed the temporary inner vertical whitespace in
HighlightandFooter