Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Figure component #1795

Merged
merged 12 commits into from
Dec 20, 2024
Merged

feat: Add Figure component #1795

merged 12 commits into from
Dec 20, 2024

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Adds a Figure component and its Caption subcomponent.

Why

To group an image or other media content with a caption.

How

Straightforwardly.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • None

@github-actions github-actions bot temporarily deployed to demo-DES-971-figure-component December 17, 2024 23:43 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-971-figure-component December 18, 2024 22:20 Destroyed
packages/css/src/components/index.scss Outdated Show resolved Hide resolved
packages/react/src/Figure/Figure.test.tsx Show resolved Hide resolved
packages/react/src/Figure/FigureCaption.test.tsx Outdated Show resolved Hide resolved
storybook/src/components/Breakout/Breakout.docs.mdx Outdated Show resolved Hide resolved
storybook/src/components/Breakout/Breakout.stories.tsx Outdated Show resolved Hide resolved
storybook/src/components/Figure/Figure.stories.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-971-figure-component December 20, 2024 15:41 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-971-figure-component December 20, 2024 15:44 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-971-figure-component December 20, 2024 15:54 Destroyed
@alimpens alimpens merged commit 3505dcc into develop Dec 20, 2024
6 checks passed
@alimpens alimpens deleted the feat/DES-971-figure-component branch December 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants