Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing keys to Breakout stories #1794

Merged
merged 3 commits into from
Dec 18, 2024
Merged

chore: Add missing keys to Breakout stories #1794

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef84e02
Add missing keys to Breakout stories
VincentSmedinga Dec 17, 2024
7c64445
Fix stacking issue
VincentSmedinga Dec 17, 2024
ba52734
Merge branch 'develop' into chore/add-keys-to-breakout-stories
alimpens Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions storybook/src/components/Breakout/Breakout.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,13 @@ type Story = StoryObj<typeof meta>
export const Default: Story = {
args: {
children: [
<Breakout.Cell colSpan="all" has="spotlight" rowSpan={{ medium: 2, narrow: 2, wide: 1 }} rowStart={2}>
<Breakout.Cell colSpan="all" has="spotlight" key={1} rowSpan={{ medium: 2, narrow: 2, wide: 1 }} rowStart={2}>
<Spotlight />
</Breakout.Cell>,
<Breakout.Cell
colSpan={{ medium: 8, narrow: 4, wide: 6 }}
colStart={1}
key={2}
rowStart={{ medium: 3, narrow: 3, wide: 2 }}
>
<Paragraph inverseColor>
Expand All @@ -42,6 +43,7 @@ export const Default: Story = {
colSpan={{ medium: 8, narrow: 4, wide: 6 }}
colStart={{ medium: 1, narrow: 1, wide: 7 }}
has="figure"
key={3}
rowSpan={2}
rowStart={1}
>
Expand All @@ -54,15 +56,16 @@ export const Default: Story = {
export const VerticalLayout: Story = {
args: {
children: [
<Breakout.Cell colSpan="all" has="figure" rowSpan={2} rowStart={1}>
<Image alt="" src="https://picsum.photos/1600/900" />
</Breakout.Cell>,
<Breakout.Cell colSpan="all" has="spotlight" rowSpan={2} rowStart={2}>
<Breakout.Cell colSpan="all" has="spotlight" key={1} rowSpan={2} rowStart={2}>
<Spotlight />
</Breakout.Cell>,
<Breakout.Cell colSpan="all" has="figure" key={2} rowSpan={2} rowStart={1}>
<Image alt="" src="https://picsum.photos/1600/900" />
</Breakout.Cell>,
<Breakout.Cell
colSpan={{ medium: 6, narrow: 4, wide: 8 }}
colStart={{ medium: 2, narrow: 1, wide: 3 }}
key={3}
rowStart={3}
>
<Paragraph className="ams-mb--sm" inverseColor>
Expand Down
Loading