Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Move alert icon into thick left border #1792

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Updates the design of Alert.

Why

The design has changed to make Alerts more prominent while adhering to the requirements of the current branding.

How

Introduced sections for the three ‘columns’ of the alert and applied CSS and tokens to them.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • UX agrees that the title of an Alert can be made required. This simplifies the placement of the close button; a PR for this will follow.
  • A default severity has not defined yet. Omitting its class name (using only ams-alert) renders an Alert with a black outline. UX indicates that the ‘info’ severity should be the default. A PR for this will follow.
  • PRs will also follow to remove the incorrect example of the list in an Alert, and new tickets will be added to the backlog to design for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant