Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade ESLint to v9 and overhaul configuration #1786

Merged
merged 20 commits into from
Dec 18, 2024
Merged

chore: Upgrade ESLint to v9 and overhaul configuration #1786

merged 20 commits into from
Dec 18, 2024

Conversation

RubenSibon
Copy link
Contributor

@RubenSibon RubenSibon commented Dec 11, 2024 •
edited
Loading

Describe the pull request

Upgrade ESLint to version 9 and overhaul the configuration for ESLint and it's plugin ecosystem.

What

  • Upgrades ESLint to version 9.x;
  • Upgrades various packages related to ESLint;
  • Introduces the flat config file for ESLint;
  • Overhauls configuration files for various ESLint plugins and TypeScript;
  • Addresses a number of lint issues that came up.

Why

ESLint v8.x reached end-of-life on 2024-10-05 and is no longer maintained.

How

By following the migration guide.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

Additional notes

@RubenSibon
feat(eslint): upgrade to v9 and flat config
2c0c370 
- Various packages were majorly or minorly upgraded.
- Configuration for ESlint and various plugins was overhauled.
@RubenSibon
fix(eslint): address lint issues
ead0b57
@RubenSibon RubenSibon self-assigned this Dec 11, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-769-upgrade-eslint-to-v9 December 11, 2024 15:13 Destroyed
@RubenSibon RubenSibon changed the title feat!: Upgrade ESlint to v9 and overhaul configuration feat!: Upgrade ESLint to v9 and overhaul configuration Dec 11, 2024
alimpens
alimpens reviewed Dec 13, 2024
View reviewed changes
eslint.config.mjs Outdated Show resolved Hide resolved
eslint.config.mjs Outdated Show resolved Hide resolved
eslint.config.mjs Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
.eslintrc.ts.json Show resolved Hide resolved
proprietary/react-icons/README.md Show resolved Hide resolved
storybook/src/components/SearchField/SearchField.stories.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-769-upgrade-eslint-to-v9 December 13, 2024 13:10 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-769-upgrade-eslint-to-v9 December 13, 2024 13:17 Destroyed
@RubenSibon RubenSibon requested a review from alimpens December 16, 2024 08:58
@VincentSmedinga VincentSmedinga mentioned this pull request Dec 16, 2024
Closed
alimpens
alimpens reviewed Dec 16, 2024
View reviewed changes
eslint.config.mjs Outdated Show resolved Hide resolved
eslint.config.mjs Outdated Show resolved Hide resolved
packages/react/documentation/coding-conventions.md Show resolved Hide resolved
storybook/src/docs/developer-guide/getting-started.docs.mdx Show resolved Hide resolved
This was referenced Dec 16, 2024
Closed
Closed
@RubenSibon
Merge branches 'feat/DES-769-upgrade-eslint-to-v9' and 'develop' of g…
df26972 
…ithub.com:Amsterdam/design-system into feat/DES-769-upgrade-eslint-to-v9
@RubenSibon
fix: remove ignore of node_modules
e2a225e 
It is part of the patterns ignored by default.
@github-actions github-actions bot temporarily deployed to demo-DES-769-upgrade-eslint-to-v9 December 16, 2024 13:15 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-769-upgrade-eslint-to-v9 December 16, 2024 13:19 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-769-upgrade-eslint-to-v9 December 16, 2024 13:22 Destroyed
@RubenSibon
Merge branch 'feat/DES-769-upgrade-eslint-to-v9' of github.com:Amster…
cac160d 
…dam/design-system into feat/DES-769-upgrade-eslint-to-v9
@RubenSibon
Merge branch 'feat/DES-769-upgrade-eslint-to-v9' of github.com:Amster…
c5b4c1a 
…dam/design-system into feat/DES-769-upgrade-eslint-to-v9
@RubenSibon
Merge branch 'feat/DES-769-upgrade-eslint-to-v9' of github.com:Amster…
0abeacd 
…dam/design-system into feat/DES-769-upgrade-eslint-to-v9
@RubenSibon
Merge branch 'feat/DES-769-upgrade-eslint-to-v9' of github.com:Amster…
6fabaa5 
…dam/design-system into feat/DES-769-upgrade-eslint-to-v9
@RubenSibon RubenSibon requested a review from alimpens December 16, 2024 13:26
@github-actions github-actions bot temporarily deployed to demo-DES-769-upgrade-eslint-to-v9 December 16, 2024 13:27 Destroyed
@alimpens alimpens changed the title feat!: Upgrade ESLint to v9 and overhaul configuration chore: Upgrade ESLint to v9 and overhaul configuration Dec 18, 2024
VincentSmedinga
VincentSmedinga approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@VincentSmedinga VincentSmedinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🎉

@VincentSmedinga VincentSmedinga merged commit 698b489 into develop Dec 18, 2024
7 checks passed
@VincentSmedinga VincentSmedinga deleted the feat/DES-769-upgrade-eslint-to-v9 branch December 18, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimpens alimpens alimpens approved these changes

@VincentSmedinga VincentSmedinga VincentSmedinga approved these changes

@dlnr dlnr Awaiting requested review from dlnr

Assignees

@RubenSibon RubenSibon

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubenSibon @VincentSmedinga @alimpens