Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Make background of Alert white again #1765

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

  1. Reverts feat!: Change colours for Alert #1757 where we added light background colours to Alert.
  2. Adds and uses a token to make the background explicitly white.

Why

  1. Our branding department doesnt’t (yet?) accept these colours.
  2. Because it was transparent, which may have side effects. It didn’t show because our Screen makes the background white, but a component must be fully responsible for its appearance. This also allows other NLDS communities to set a different background colour.

How

Changed tokens and classes.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • None

@alimpens alimpens merged commit 2a59067 into develop Nov 27, 2024
6 checks passed
@alimpens alimpens deleted the feature/DES-1072-revert-alert-colours branch November 27, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants