Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Replace renamed colours for Avatar, Badge and Spotlight #1758

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

VincentSmedinga
Copy link
Contributor

@VincentSmedinga VincentSmedinga commented Nov 19, 2024

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

This updates some changed colour names as options for the color prop of Avatar, Badge and Spotlight.

Why

To reflect the changes in underlying colour names.

How

Find, replace, sort, test.

I’ve committed the renames separately from the sorting – reviewing the renaming commits separately may be more insightful than checking the full diff.

Additional notes

  1. We may not need all four neutral shades for Avatar and Badge. Let’s address this separately – this PR only does renaming.
  2. If we do want to keep them, the neutral-xx names may not be the best API. Should we find colour names that match the others here? This could be done in this PR, as it is just a different rename.
  3. Blue may not be the best default value for Spotlight, as we only want the Footer to be such a blue area.
  4. Blue may not be the best default value for Avatar, until it can be made interactive.

@github-actions github-actions bot temporarily deployed to demo-DES-1068-update-color-prop-values November 19, 2024 20:41 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1068-update-color-prop-values November 20, 2024 08:44 Destroyed
@VincentSmedinga VincentSmedinga merged commit 5c8132a into develop Nov 20, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-1068-update-color-prop-values branch November 20, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants