Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade ESLint to v9 (WIP) #1754

Closed
wants to merge 7 commits into from

Conversation

RubenSibon
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

(What changes does this PR introduce?)

Why

(Why are these changes necessary?)

How

(How were these changes implemented? Provide a brief overview of the approach taken and any key considerations.)

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

package.json Outdated
@@ -101,5 +107,5 @@
"cookie@<0.7.0": ">=0.7.0"
}
},
"packageManager": "pnpm@9.12.2+sha512.22721b3a11f81661ae1ec68ce1a7b879425a1ca5b991c975b074ac220b187ce56c708fe5db69f4c962c989452eee76c82877f4ee80f474cebd61ee13461b6228"
"packageManager": "pnpm@9.13.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json Outdated
Comment on lines 30 to 32
"@eslint/compat": "1.2.3",
"@eslint/eslintrc": "3.1.0",
"@eslint/js": "9.14.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all devDependencies, right?

@github-actions github-actions bot temporarily deployed to demo-DES-769-eslint-v9-upgrade November 29, 2024 16:30 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-769-eslint-v9-upgrade December 11, 2024 09:33 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-769-eslint-v9-upgrade December 11, 2024 12:56 Destroyed
@RubenSibon
Copy link
Contributor Author

Closing this PR as a new branch was made based off more recent to commits to develop.

@RubenSibon RubenSibon closed this Dec 11, 2024
@RubenSibon RubenSibon deleted the feat/DES-769-eslint-v9-upgrade branch December 11, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants