Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Icon to Error Message #1746

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Nov 6, 2024

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

Adds an Icon to Error Message

Why

Error Message wasn't very prominent, and for colour-blind people or people using high contrast themes the Error Message wasn't very noticeable.

How

By adding a default icon and an icon prop.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

The ticket specifies to add the Icon the same way we did for Radio. This isn't quite possible though, because we use the Icon component here, and it needs a Function instead of a ReactNode. We plan on changing this in the future though.

@VincentSmedinga VincentSmedinga merged commit eca5fe4 into develop Nov 6, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-967-add-icon-to-error-message branch November 6, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants