Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Page control re-renders entire component #1737

Merged

Conversation

RubenSibon
Copy link
Contributor

@RubenSibon RubenSibon commented Nov 1, 2024

Describe the pull request

What

The page control in Storybook did not re-render the entire component such that the active page changed.

Why

Because the page control should change the selected number in the Pagination.

How

A key prop that is mapped to the args causes the component to completely re-render when one of the arguments change.

Checklist

  • Add or update stories
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

@RubenSibon RubenSibon self-assigned this Nov 1, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-1011-storybook-pagination-page-control November 8, 2024 15:21 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1011-storybook-pagination-page-control November 8, 2024 15:23 Destroyed
@VincentSmedinga VincentSmedinga merged commit 473f740 into develop Nov 8, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the fix/DES-1011-storybook-pagination-page-control branch November 8, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants