Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert using SHAs in GitHub workflows #1706

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

alimpens
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

It reverts using SHAs instead of version numbers in our GitHub workflows.

Why

Using SHAs is a good idea (see this for more info), but our organisation GitHub Action allowlist uses version number currently, which means the Actions using SHAs are blocked. We have to change the allowlist first before implementing this again.

How

Copy-pasting the old values back. I couldn't revert the files in their entirety, because I wanted to keep some of the changes.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

@VincentSmedinga VincentSmedinga merged commit ee4cee0 into develop Oct 28, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the task/revert-gh-actions-sha branch October 28, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants