feat!: Replace Aspect Ratio component with utility classes and prop on Image #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/DES-834-aspect-ratio-comp-to-prop
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
… of github.com:Amsterdam/design-system into feat/DES-834-aspect-ratio-comp-to-prop
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
…t/DES-834-aspect-ratio-comp-to-prop
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
…t/DES-834-aspect-ratio-comp-to-prop
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
VincentSmedinga
changed the title
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
dlnr
previously approved these changes
Nov 8, 2024
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
alimpens
reviewed
Nov 8, 2024
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-834-aspect-ratio-comp-to-prop
VincentSmedinga
approved these changes
Nov 8, 2024
VincentSmedinga
changed the title
alimpens
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Simplifies giving (media) elements fixed two dimensional aspect ratios.
What
Converts the Aspect Ratio component to a just tokens, CSS classes and an
aspectRatioproperty onImage.Why
Simplification: less components and overhead by using component properties, CSS classes or tokens.
How
Removing the Aspect Ratio React component with exception of the types.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes
aspectRatioproperty onImage. It may be added to more (media) elements, such asVideoin the future.Figurecomponent.