chore: Improve presentation of design token tables #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
changed the title
This reverts commit 041a4c6. # Conflicts: # storybook/src/foundation/design-tokens/space.docs.mdx
alimpens
reviewed
Jul 26, 2024
alimpens
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that the space token previews would shrink with the window size. Seems logical because we use the actual tokens for their widt. On the other hand, we display these for their largest width only and the idea is to show the slope of the scale. That’s better done by expressing the largest values in rems, which don’t depend on the window size but do scale with text if people choose to do so.
The tables in the Space docs now show the full token names (
ams-space-xx) instead of just the size (xx) – they are in the ‘Design Tokens’ section after all, and this matches how we displayed it for Borders. Then, having ‘Extra Small’ etc. as row headings didn’t add that much anymore so I merged those.Some other changes too to make things easier to grasp. And ‘example’ instead of ‘preview’: we use ‘Examples’ for stories as well.