Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add horizontal and vertical alignment options to Column #1428

Merged
merged 14 commits into from
Jul 24, 2024
Merged

feat: Add horizontal and vertical alignment options to Column #1428

merged 14 commits into from
Jul 24, 2024

Conversation

VincentSmedinga
Copy link
Contributor

@VincentSmedinga VincentSmedinga commented Jul 22, 2024 •
edited
Loading

  • Adds the same alignment properties to Column as feat: Add horizontal and vertical alignment options to Row #1330 did for Row.
  • Improves the examples in both Row and Column
    • Visualizes the flex container through a striped background
    • Sets its width and height for better impression of alignment use cases
    • Simplifies the class names used
    • Adds JSDoc and a separate type to optimize Storybook Controls
    • Hides other props from specific examples – the Default example will always have all props

@github-actions github-actions bot temporarily deployed to demo-DES-881-column-alignment July 22, 2024 16:01 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-881-column-alignment July 23, 2024 22:50 Destroyed
alimpens
alimpens reviewed Jul 24, 2024
View reviewed changes
packages/react/src/Column/Column.tsx Show resolved Hide resolved
storybook/src/components/Column/Column.docs.mdx Outdated Show resolved Hide resolved
storybook/src/components/Column/Column.stories.tsx Outdated Show resolved Hide resolved
storybook/src/components/Row/Row.stories.tsx Outdated Show resolved Hide resolved
storybook/src/components/Row/Row.stories.tsx Outdated Show resolved Hide resolved
@VincentSmedinga VincentSmedinga mentioned this pull request Jul 24, 2024
Merged
@github-actions github-actions bot temporarily deployed to demo-DES-881-column-alignment July 24, 2024 11:25 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-881-column-alignment July 24, 2024 11:35 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-881-column-alignment July 24, 2024 12:18 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-881-column-alignment July 24, 2024 12:22 Destroyed
@VincentSmedinga
Merge branch 'develop' into feature/DES-881-column-alignment
0cb02aa 
# Conflicts:
#	storybook/config/preview-body.html
#	storybook/src/components/Column/Column.docs.mdx
#	storybook/src/components/Column/Column.stories.tsx
#	storybook/src/components/Row/Row.stories.tsx
@github-actions github-actions bot temporarily deployed to demo-DES-881-column-alignment July 24, 2024 12:51 Destroyed
@VincentSmedinga VincentSmedinga requested a review from alimpens July 24, 2024 12:59
@alimpens alimpens merged commit d5a7766 into develop Jul 24, 2024
5 checks passed
@alimpens alimpens deleted the feature/DES-881-column-alignment branch July 24, 2024 13:04
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimpens alimpens alimpens approved these changes

@dlnr dlnr Awaiting requested review from dlnr

@RubenSibon RubenSibon Awaiting requested review from RubenSibon

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentSmedinga @alimpens