Skip to content

Commit

Permalink
fix: address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
RubenSibon committed Dec 13, 2024
1 parent b9e430b commit 40cb206
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 12 deletions.
10 changes: 4 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,23 +139,21 @@ You can use any editor you like, but if you use [Visual Studio Code](https://cod

To enable correct validation and to fix lint/style errors on save, add this to your VSCode `settings.json`:

<!-- eslint-disable -->

```json
{
"eslint.useFlatConfig": true,
"css.validate": false,
"scss.validate": false,
"stylelint.validate": ["css", "scss"],
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true,
"source.fixAll.stylelint": true,
"source.fixAll.stylelint": true
},
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true,
"editor.formatOnSave": true
}
```

<!-- eslint-enable -->

</details>

### Run storybook
Expand Down
3 changes: 1 addition & 2 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export default tseslint.config(
react: { version: 'detect' },
},
rules: {
'@typescript-eslint/consistent-type-definitions': ['error', 'type'],
'array-callback-return': [
'error',
{
Expand Down Expand Up @@ -229,8 +230,6 @@ export default tseslint.config(
rules: {
...mdx.flatCodeBlocks.rules,
'@typescript-eslint/no-unused-vars': 'off',
'no-undef': 'off',
'react/jsx-no-undef': 'off',
},
},
)
9 changes: 5 additions & 4 deletions proprietary/react-icons/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@ npm install @amsterdam/design-system-react-icons

Import the component for the icon you need, as well as the generic Icon component, and use them in your JSX.

```ts
import { Icon } from "@amsterdam/design-system-react";
import { SearchIcon } from "@amsterdam/design-system-react-icons";
<!-- prettier-ignore -->
```tsx
import { Icon } from "@amsterdam/design-system-react"
import { SearchIcon } from "@amsterdam/design-system-react-icons"

export const App = () => <Icon svg={SearchIcon} />;
export const App = () => <Icon svg={SearchIcon} />
```

## Updating
Expand Down

0 comments on commit 40cb206

Please sign in to comment.